-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Clarifying Commands' purpose #10837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarifying Commands' purpose #10837
Conversation
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
"Structural changes" is not a well-known term. In the entire Bevy docs, this is only mentioned once:
This change is technically correct I suppose, but without that additional explanation added, this change would be meaningless for most people. If you start using "structural changes" in docs, you should define somewhere what it means exactly (not necessarily in Commands, just somewhere). |
😮 Ahhh okay that makes sense, im willing to add additional information or provide an example of what it means to "structurally change" something. Since this is the first time I am contributing to an open-source project and im not too familiar with the whole process, should this additional change, you have suggested, be dicussed with the original issuer? or should this be created as another issue? |
Nah, don't bother, it's merged already, and it is in my opinion isn't worth a commit. You can consider it as a note in case someone decides to make similar changes elsewhere. |
oooh okay, ill definitely keep this in mind in the future! 😄 |
Objective
As described in Issue #10805 I have changed "impactful changes" to "structural changes"
Solution
Updated the text "impactful" to "structural"