Arrow Head Generalization #10661
Arrow Head Generalization #10661
Conversation
alice-i-cecile
added
C-Feature
crates/bevy_gizmos/src/arrows.rs
Outdated
| /// } | ||
| /// # bevy_ecs::system::assert_is_system(system); | ||
| /// ``` | ||
| pub fn with_double_ended(&mut self, state: bool) { |
There was a problem hiding this comment.
Why not split this into with_double_ended and with_single_ended, and remove the bool arg?
There was a problem hiding this comment.
I didn't see any parcticular reason to do it as one or two functions so i just picked one because it was less typing /shrug
either way is fine by me.
There was a problem hiding this comment.
Yeah, I think that two functions will be nicer to use for end users because in 99% of cases you'll just call this once to toggle double-ended.
There was a problem hiding this comment.
Idk but with_.._ended sounds weird to me. What about this:
gizmos.arrow().with_ending(ArrowEnding::Single);
gizmos.arrow().with_ending(ArrowEnding::Double)?
There was a problem hiding this comment.
Or if we later want multiple styles of ending:
gizmos.arrow().with_endings((ArrowEnding::None, ArrowEnding::Normal));There was a problem hiding this comment.
gizmos.arrow().with_tips(ArrowTip::None, ArrowTip::Normal);Gets my vote.
There was a problem hiding this comment.
gizmos.arrow().with_endings((ArrowEnding::None, ArrowEnding::Normal));
I like this idea but I think there should still be single_ended and double_ended methods for simpler use-cases
There was a problem hiding this comment.
scope creep time!
There was a problem hiding this comment.
These cover all 4 possible combinations of tips for almost all use cases:
gizmos.line()
gizmos.arrow()
gizmos.double_arrow()There's no need for additional flexibility in debug gizmos... but you can do this:
gizmos.double_arrow()
.with_front_tip(ArrowTip {
length: 10.,
color: Color::WHITE,
style: ArrowStyle::Kitten,
..default()
})There was a problem hiding this comment.
yeah. the more i write down the scope-crept version in my head the more i realize it's a bad idea.
|
my adhd knows no boundries. scope creep time. |
|
I think my first idea (maybe with shorter method names on ArrowBuilder) was better, or just adding |
|
if you really want a double-headed arrow just do a second arrow pointing the other way tbh |
Objective
Solution
Changelog
Migration Guide