prepare_view_upscaling_pipelines is ambiguous with dozens of other systems
#14770
Labels
A-Rendering
Drawing game state to the screen
C-Bug
An unexpected or incorrect behavior
D-Straightforward
Simple bug fixes and API improvements, docs, test and examples
S-Ready-For-Implementation
This issue is ready for an implementation PR. Go for it!
X-Contentious
There are nontrivial implications that should be thought through
Comments
alice-i-cecile
added
C-Bug
|
Both ambiguous_with_all and allow_ambiguous_resource are reasonable, but I'd prefer the former because it's more localized. |
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 16, 2024
# Objective The `prepare_view_upscaling_pipelines` system has dozens of ambiguities, which makes it harder to spot and prevent new ambiguities. Closes #14770. ## Solution Just exclude the system from ambiguity detection. See the linked issue for more context on why this resolution was chosen. ## Testing Running the `ambiguity_detection` example now reports dozens fewer `Render` app ambiguities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bevy version
a2fc9de
What you did
cargo run --example ambiguity_detectionWhat went wrong
prepare_view_upscaling_pipelinesis ambiguous with dozens of other systems, such asprepare_preprocess_bind_groupsThis system uses
ResMut<PipelineCache>, while every other system usesRes(via interior mutability).Additional information
This was discovered as part of #7386. This system should run after all of its siblings, but doing so is quite intrusive.
@JMS55 suggests that we tackle this by making
PipelineCache::block_onuse interior mutability. Overall, the design here doesn't seem perfect. I'm inclined to just silence the ambiguity for now (which will have a similar effect) until a better solution is found.The text was updated successfully, but these errors were encountered: