Support PBKDF2 using SHA512 #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29decibel
force-pushed
the
mike/pbkdf2
branch
5 times, most recently
from
eeceb56 to
72ea687
Compare
29decibel
force-pushed
the
mike/pbkdf2
branch
from
72ea687 to
a09652b
Compare
tneems
reviewed
Jan 30, 2023
| module Encryptors | ||
| # https://en.wikipedia.org/wiki/PBKDF2 | ||
| # Adapted from https://gitlab.com/gitlab-org/gitlab/-/blob/373f088e755f678478b8dd1627fab908d2641b21/vendor/gems/devise-pbkdf2-encryptable/lib/devise/pbkdf2_encryptable/encryptors/pbkdf2_sha512.rb | ||
| class Pbkdf2 < Base |
There was a problem hiding this comment.
I think my primary discomfort with this is the potential for a name with devise encryptable clash if/when the original PR gets merged. Maybe change the class name to something like Pbkdf2Hash?
f1sherman
approved these changes
Jan 31, 2023
Author
|
Close this in favor of #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR and adopting ideas from Gitlab's PBKDF2 implementation.
Key change is to the
Pbkdf2encryptor class to buildsaltandstretchesinto the hash, same strategy with Bcrypt. So this change would allow us to changeiterationscount in the future without breaking existing hashed passwords usingPbkdf2