Skip to content

feat: add detailed steps and timeline for Philippines 13A visa application process#456

Open
gabconcepcionph wants to merge 8 commits into
bettergovph:mainfrom
gabconcepcionph:feature/visa-steps-structured-ui
Open

feat: add detailed steps and timeline for Philippines 13A visa application process#456
gabconcepcionph wants to merge 8 commits into
bettergovph:mainfrom
gabconcepcionph:feature/visa-steps-structured-ui

Conversation

@gabconcepcionph
Copy link
Copy Markdown

  • Added initial page to support Step (optional) process per visa type
  • Added structural Playwright coverage for
  • src/pages/travel/visa-types/index.tsx to ensure hero, category sidebar, and visa cards render correctly.
  • Validated layout for src/pages/travel/visa-types/[type].tsx, including minimum requirements, optional steps, and subtypes cards tied to the expanded 13A data.

Testing
npx playwright test e2e/travel/visa-types.spec.ts

With steps
Screenshot 2025-10-13 at 12 57 09 PM

Without steps
Screenshot 2025-10-13 at 12 58 47 PM

@niculistana
Copy link
Copy Markdown
Collaborator

niculistana commented Oct 15, 2025

@gabconcepcionph Can this be an accordion instead? This would ensure that each step has more details and the user doesn't have to scroll too much.

Feel free to use this doc as reference: https://ui.shadcn.com/docs/components/accordion

Comment thread e2e/travel/visa-types.spec.ts Outdated
@@ -0,0 +1,85 @@
import { expect, test } from '@playwright/test';

test.describe('Philippine visa types', () => {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test.describe('Philippine visa types', () => {

Since tests do not share contexts, this should be safe to remove. It's best to use test.describe() when creating tests with shared contexts.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refrain from using the locator() method and manually specifying the HTML tags or xpath to locate an element. Please use the getByRole() method instead.

locator() is best used when you are trying to narrow down elements to locate then paired with getByRole()

@angelofallars angelofallars added needs-content-review mid priority This project is needed but can take its time. e2e-test labels Oct 16, 2025
@DaijobuDes DaijobuDes added the pending This is currently being worked on (on-going). label Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e-test mid priority This project is needed but can take its time. needs-content-review pending This is currently being worked on (on-going).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants