Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork/integrate wayfinder changes #610

Draft
wants to merge 78 commits into
base: main
Choose a base branch
from

Conversation

rsmithlal
Copy link
Member

@rsmithlal rsmithlal commented Nov 26, 2024

Summary: Integration of Wayfinder Changes

This pull request introduces numerous updates and improvements as part of integrating the Wayfinder changes into the Better Together Rails project. The changes span theming, navigation enhancements, content block updates, caching optimizations, and bug fixes. These updates aim to improve performance, usability, and feature extensibility.


Key Changes

1. Theming Enhancements:

  • Initial theming support for the New to NL project.
  • Expanded theming using a color palette for cohesive branding.
  • Applied themes to Turbo progress bars and navigation underlines.
  • Customized range slider styles for a better user experience.
  • Updated body background images to align with the project theme.

2. Navigation Improvements:

  • Added sidebar navigation to pages for improved usability.
  • Enhanced navigation styling, including active link underlines.
  • Added a custom scroll bar to indicate the user's position on the page.
  • Triggered navigation active state dynamically on user interaction.
  • Implemented children counter cache for navigation items.

3. Content Block Updates:

  • Added support for custom profile and cover images.
  • Introduced privacy and identifier columns for content blocks.
  • Improved consistent rendering of profile and cover images across views.
  • Standardized styling for host management controllers and views.

4. Caching and Performance Optimization:

  • Configured Redis for caching in the development environment.
  • Optimized caching for navigation components and assets.
  • Reduced database queries and improved load times for frequently accessed components.

5. Translation and Localization:

  • Installed model translations to enhance localization support.
  • Wrapped routes in locale scopes to ensure multi-language compatibility.
  • Removed redundant translation keys present in the better_together gem.

6. Metrics and Analytics:

  • Added engagement metrics database tables for tracking user activity.
  • Configured Sidekiq production queues for better background job management.

7. Docker and Development Tooling:

  • Updated docker-compose.yml with additional configuration options.
  • Documented the Docker setup to streamline development workflows.

8. Bug Fixes:

  • Resolved asset pipeline issues related to SCSS and JavaScript imports.
  • Fixed root path routing and redirection issues.
  • Ensured file types are properly identified during SCSS imports.

Technical Improvements:

  • Refactored Stimulus controllers under the better_together namespace.
  • Configured Mailhog for development email testing.
  • Precompiled manifest files for production readiness.
  • Addressed Rubocop and Brakeman warnings for code quality and security.

Dependencies Updated:

  • Upgraded various gems for improved functionality, including:
    • rubocop-rspec from 3.0.5 to 3.2.0
    • fog-aws from 3.27.0 to 3.29.0
    • sidekiq from 7.3.2 to 7.3.4
    • pg from 1.5.8 to 1.5.9
    • brakeman from 6.2.1 to 6.2.2

Future Considerations:

This PR provides the foundation for additional improvements, including:

  • Extending engagement metrics tracking and analytics.
  • Refining theming capabilities for more customization options.
  • Further optimizing navigation and content block rendering.

Includes initial colour palette implementation and visual adjustments
Set typography, add sticky nav, improve button hover transition, give links green-2 colour on hover, and translate cards on hover
Update better_together

Update better_together

Update better_together sticky footer placement
Update better_together

Update better_together to include auto-localized mailers
** TODO: Don't forget to add versions of these files in the Community Engine gem, too. It will break without them in place when rendering default profile images. **

Update better_together
…reparation for the first of the NewToNL project's JS files
…ifest to fix broken bootstrap JS

Update better_together
Update better_together

Update better_together
Added NewToNL models to host dashboard, add timestamps to resources table

update better_together
Update better_together

Update better_together
dependabot bot and others added 10 commits November 25, 2024 21:54
Bumps [brakeman](https://github.com/presidentbeef/brakeman) from 6.2.1 to 6.2.2.
- [Release notes](https://github.com/presidentbeef/brakeman/releases)
- [Changelog](https://github.com/presidentbeef/brakeman/blob/main/CHANGES.md)
- [Commits](presidentbeef/brakeman@v6.2.1...v6.2.2)

---
updated-dependencies:
- dependency-name: brakeman
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [database_cleaner](https://github.com/DatabaseCleaner/database_cleaner) from 2.0.2 to 2.1.0.
- [Changelog](https://github.com/DatabaseCleaner/database_cleaner/blob/main/History.rdoc)
- [Commits](DatabaseCleaner/database_cleaner@v2.0.2...v2.1.0)

---
updated-dependencies:
- dependency-name: database_cleaner
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails) from 6.4.3 to 6.4.4.
- [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases)
- [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/main/NEWS.md)
- [Commits](thoughtbot/factory_bot_rails@v6.4.3...v6.4.4)

---
updated-dependencies:
- dependency-name: factory_bot_rails
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rspec@v3.1.0...v3.2.0)

---
updated-dependencies:
- dependency-name: rubocop-rspec
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
update better_together

add initial ai translation capability
Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.25.0 to 4.26.0.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES)
- [Commits](SeleniumHQ/selenium@selenium-4.25.0...selenium-4.26.0)

---
updated-dependencies:
- dependency-name: selenium-webdriver
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Update better_together

Includes massive performance improvements rendering sidebar nav items
update better_together

Fix journey map person profile tab and optimized background images for various formats
…ckfile

Update better_together

Fix triggering journey nav item clicking on my journey tab

update better_together

add password toggle on sign in form

update better_together

Improved utility of two graph reports
@rsmithlal rsmithlal self-assigned this Nov 28, 2024
@rsmithlal rsmithlal added the enhancement New feature or request label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant