Skip to content

Support for further encodings added#298

Open
pjsharp wants to merge 3 commits intobetonme:py2from
pjsharp:py2
Open

Support for further encodings added#298
pjsharp wants to merge 3 commits intobetonme:py2from
pjsharp:py2

Conversation

@pjsharp
Copy link

@pjsharp pjsharp commented Dec 16, 2022

  • support for encodings iso-8859-[1..4] and freesat huffman added
  • code improvements

pjsharp and others added 3 commits November 8, 2022 21:54
Extension of the support for further encodings according to the specification ETSI EN 300 468
- repetitive calls have been encapsulated into the methods
- code improvements

(cherry picked from commit 582069a)
@dhwz dhwz self-requested a review December 22, 2022 23:54
@pjsharp pjsharp closed this Feb 13, 2023
@dhwz dhwz reopened this Feb 13, 2023
Repository owner deleted a comment from pjsharp Feb 13, 2023
@pjsharp
Copy link
Author

pjsharp commented Feb 15, 2023

This code version is long obsolete. There is a newer one that doesn't need EitSupport and MetaSupport anymore. This is already merged in the current branch for PY3.

It's pointless to keep opening this PR and deleting my comments (also in other issues)!

@pjsharp pjsharp closed this Feb 15, 2023
@dhwz
Copy link
Collaborator

dhwz commented Feb 15, 2023

Stop commeting on issues on this repo if you don't add changes here, this is the official EMC repository, it's not our fault the PY3 changes were not PRed, the repo is open to everyone.

@dhwz dhwz reopened this Feb 15, 2023
@pjsharp
Copy link
Author

pjsharp commented Feb 15, 2023

I was asked by jbleyel to look at the issues. The changes were merged in the fork which is currently used to build images (OATV 7.2) and used in the current feed

@dhwz
Copy link
Collaborator

dhwz commented Feb 15, 2023

Right now you're just committing to a repo which doesn't keep compatibility with other images, by removing modules you already broke compatibility with others, main focus of EMC was always to make it run on any image.

@pjsharp
Copy link
Author

pjsharp commented Feb 15, 2023

I didn't break any compatibility. I only removed code parts that are not necessary because they are natively supported by all E2 and now the reading of EventInfos will do like in all E2.

@dhwz
Copy link
Collaborator

dhwz commented Feb 15, 2023

How can you tell it's working everywhere? Did you test it? On DreamOS, on older E2 forks?

@pjsharp
Copy link
Author

pjsharp commented Feb 15, 2023

Not exactly with all of them. For example, I don't have a Dreambox. But the code parts I used now for EventInfo were already present in the existing code in different places before. There is actually nothing new inside, just unified, refactored and removed the unnecessary. If the code should no longer be compatible, then the compatibility was not given until now also.

And the issue area in the repo is common, other forks don't have their own issue area. So if you locked it, you take away the possibility for other users to be informed that there is a solution to their problems.

But whatever. I just wanted to help others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants