Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import des champs other_effects et other_conditions des déclarations historiques #1574

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

pletelli
Copy link
Collaborator

@pletelli pletelli commented Jan 31, 2025

Cette PR se base sur #1573

  • other_effects
  • other_conditions

@pletelli pletelli requested review from hfroot and alemangui and removed request for hfroot January 31, 2025 18:06
@alemangui alemangui changed the base branch from staging to fix-missing-id February 3, 2025 09:33
@alemangui
Copy link
Collaborator

alemangui commented Feb 3, 2025

@pletelli le test data.tests.test_teleicare_history_importer.TeleicareHistoryImporterTestCase.test_create_declaration_from_history échoue mais je ne suis pas sur pourquoi - ça a l'air de venir du teardown.

J'ai essayé de changer la base de la branche à fix-missing-id mais ça n'a pas changé.

Par contre le code me semble OK. Une fois le test réglé je suis OK pour merge 🚀

Base automatically changed from fix-missing-id to staging February 3, 2025 10:11
@pletelli pletelli marked this pull request as draft February 3, 2025 10:22
@pletelli pletelli marked this pull request as ready for review February 4, 2025 09:49
@pletelli pletelli merged commit 75d074a into staging Feb 4, 2025
5 checks passed
@pletelli pletelli deleted the other_effects branch February 4, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants