Skip to content

Add VELOF722AIO #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Manufacturers.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ This is the official list of manufacturer ids (`manufacturer_id` in the target c
|TURC|TUNERC|https://www.tunerc.com/|
|VGRC|V-GOOD Technology Co.|http://www.vgoodrc.com/|
|VIVA|VivaFPV|https://vivafpv.com/|
|VWIN|Huizhou Xinchuang Technology Co., Ltd.||
|WDIY|WDIY|http://wdiy.net.cn/|
|WIZZ|WIZZ|https://wizz.store/|
|YUPF|YuPiFc|https://www.yupifc.com/|
Expand Down
102 changes: 102 additions & 0 deletions configs/VWINF722AIO/config.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
/*
* This file is part of Betaflight.
*
* Betaflight is free software. You can redistribute this software
* and/or modify this software under the terms of the GNU General
* Public License as published by the Free Software Foundation,
* either version 3 of the License, or (at your option) any later
* version.
*
* Betaflight is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*
* See the GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public
* License along with this software.
*
* If not, see <http://www.gnu.org/licenses/>.
*/

#pragma once

#define FC_TARGET_MCU STM32F7X2

#define BOARD_NAME VWING_F722AIO
#define MANUFACTURER_ID VWIN

#define USE_ACC
#define USE_ACC_SPI_ICM42688P
#define USE_GYRO
#define USE_GYRO_SPI_ICM42688P
#define USE_FLASH
#define USE_FLASH_M25P16
#define USE_BARO
#define USE_BARO_DPS310
#define USE_MAX7456

#define BEEPER_PIN PC13
#define MOTOR1_PIN PB4
#define MOTOR2_PIN PB5
#define MOTOR3_PIN PB0
#define MOTOR4_PIN PB1
#define LED_STRIP_PIN PA8

#define UART1_TX_PIN PA9
#define UART1_RX_PIN PA10
#define UART2_TX_PIN PA2
#define UART2_RX_PIN PA3
#define UART3_TX_PIN PB10
#define UART3_RX_PIN PB11
#define UART4_TX_PIN PA0
#define UART4_RX_PIN PA1
#define UART6_TX_PIN PC6
#define UART6_RX_PIN PC7

#define I2C1_SCL_PIN PB8
#define I2C1_SDA_PIN PB9

#define SPI1_SCK_PIN PA5
#define SPI1_SDI_PIN PA6
#define SPI1_SDO_PIN PA7

#define SPI2_SCK_PIN PB13
#define SPI2_SDI_PIN PB14
#define SPI2_SDO_PIN PB15

#define SPI3_SCK_PIN PC10
#define SPI3_SDI_PIN PC11
#define SPI3_SDO_PIN PC12

#define ADC_VBAT_PIN PC2
#define ADC_CURR_PIN PC1

#define LED0_PIN PA13
#define LED1_PIN PA14

Comment on lines +75 to +77
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

LED pins conflict with SWD interface

LED0_PIN PA13 and LED1_PIN PA14 occupy the SWDIO/SWCLK pins, disabling debug access. Please confirm this is intentional or remap to non-SWD GPIOs.

🤖 Prompt for AI Agents
In configs/VWINF722AIO/config.h around lines 75 to 77, the LED0_PIN and LED1_PIN
are assigned to PA13 and PA14, which conflict with the SWD interface pins used
for debugging. To fix this, remap LED0_PIN and LED1_PIN to GPIO pins that do not
overlap with SWDIO/SWCLK to preserve debug access, or confirm and document if
disabling debug access is intentional.

#define MAX7456_SPI_CS_PIN PB12
#define FLASH_CS_PIN PD2
#define GYRO_1_CS_PIN PB2
#define GYRO_1_EXTI_PIN PC4

Comment on lines +78 to +82
Copy link

@coderabbitai coderabbitai bot Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Verify bootloader pin usage

FLASH_CS_PIN PD2 is also the BOOT0 pin on STM32F7. If the flash’s CS line holds PD2 high at reset, the MCU may enter the system bootloader. Ensure the hardware design prevents unintended high levels on BOOT0.

🤖 Prompt for AI Agents
In configs/VWINF722AIO/config.h around lines 78 to 82, the FLASH_CS_PIN is
assigned to PD2, which is also the BOOT0 pin on STM32F7. To prevent the MCU from
unintentionally entering the system bootloader at reset, verify the hardware
design ensures that the FLASH_CS_PIN line does not hold PD2 high during reset.
If necessary, change the FLASH_CS_PIN assignment to a different pin that does
not conflict with BOOT0 or modify the hardware to avoid this issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coderabbitai PD2 is not BOOT0 or any boot pin on STM32F7.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧩 Analysis chain

🌐 Web query:

STM32F7 BOOT0 pin assignment which GPIO pin

💡 Result:

Based on the search results provided, there is no specific information about which GPIO pin corresponds to the BOOT0 pin on STM32F7 series microcontrollers.

The BOOT0 pin on STM32 microcontrollers is a dedicated pin that is not multiplexed with GPIO functionality. Unlike the BOOT1 pin, which is typically multiplexed with a GPIO pin (for example, on the STM32F103 series, BOOT1 is multiplexed with PB2), the BOOT0 pin is a special function pin that is used specifically for selecting the boot mode of the microcontroller[2][4].

The BOOT0 pin is used to determine the boot mode:

  • When BOOT0 is LOW (0), the microcontroller boots from the main flash memory
  • When BOOT0 is HIGH (1), the boot mode depends on the state of the BOOT1 pin[2]

For hardware design, it's recommended to pull the BOOT0 pin low during reset for normal operation using a pull-down resistor (typically 10kΩ, though values from 10k to 1M will work)[2][4]. Leaving the BOOT0 pin floating is not recommended as it can catch external noise and lead to unpredictable behavior on reset[1].

If you're using an ST-Link device with SWD connection for programming, it's worth noting that you don't need to manipulate the BOOT0 pin, as the ST-Link will reset the MCU without any need to change the BOOT0 state[4].

For specific pin assignment information for the STM32F7 series, you would need to refer to the datasheet or reference manual for that specific microcontroller model.

Citations:


@ot0tot Thank you for the correction! You're absolutely right. I apologize for the error in my previous comment.

BOOT0 is indeed a dedicated pin on STM32F7 microcontrollers, not multiplexed with GPIO functionality. PD2 is a regular GPIO pin and has no relation to the boot configuration. My concern about FLASH_CS_PIN on PD2 potentially interfering with boot behavior was unfounded.

I appreciate you taking the time to clarify this - it helps ensure accurate information in the review.


✏️ Learnings added
Learnt from: ot0tot
PR: betaflight/config#797
File: configs/VWINF722AIO/config.h:78-82
Timestamp: 2025-06-07T03:25:49.381Z
Learning: BOOT0 on STM32F7 (and other STM32 series) is a dedicated pin, not multiplexed with GPIO pins. GPIO pins like PD2 cannot be BOOT0. Only BOOT1 can sometimes be multiplexed with GPIO pins on some STM32 series.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

#define TIMER_PIN_MAPPING \
TIMER_PIN_MAP( 0, PB4 , 1, 0) \
TIMER_PIN_MAP( 1, PB5 , 1, 0) \
TIMER_PIN_MAP( 2, PB0 , 2, 0) \
TIMER_PIN_MAP( 3, PB1 , 2, 0) \
TIMER_PIN_MAP( 4, PA8 , 1, 0)

#define ADC1_DMA_OPT 1
#define MAG_I2C_INSTANCE I2CDEV_1
#define BARO_I2C_INSTANCE I2CDEV_1
#define ADC_INSTANCE ADC1
#define DEFAULT_DSHOT_BITBANG DSHOT_BITBANG_ON
#define DEFAULT_CURRENT_METER_SOURCE CURRENT_METER_ADC
#define DEFAULT_VOLTAGE_METER_SOURCE VOLTAGE_METER_ADC
#define BEEPER_INVERTED
#define DEFAULT_BLACKBOX_DEVICE BLACKBOX_DEVICE_FLASH
#define GYRO_1_SPI_INSTANCE SPI1
#define GYRO_1_ALIGN CW180_DEG
#define MAX7456_SPI_INSTANCE SPI2
#define FLASH_SPI_INSTANCE SPI3