-
Notifications
You must be signed in to change notification settings - Fork 161
Add BETAFPVH725 #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add BETAFPVH725 #752
Conversation
58f71e7
to
a3a9ccf
Compare
WalkthroughA new configuration header file for the BETAFPVH725 flight controller board has been added. This file defines the hardware abstraction layer, specifying MCU type, board identifiers, enabled peripherals, pin assignments, timer mappings, ADC/I2C/SPI/UART configurations, and default device settings for various sensors and interfaces. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Firmware
participant BETAFPVH725 Board
User->>Firmware: Build with BETAFPVH725 target
Firmware->>BETAFPVH725 Board: Initialize hardware using config.h
BETAFPVH725 Board->>Firmware: Provide pin mappings and peripheral settings
Firmware->>BETAFPVH725 Board: Enable peripherals (Gyro, ACC, Baro, Flash, OSD, etc.)
Firmware->>BETAFPVH725 Board: Assign UART, SPI, I2C, ADC, and Timer resources
Firmware->>BETAFPVH725 Board: Set default device and meter sources
Note over Firmware,BETAFPVH725 Board: Board operates with configured hardware abstraction
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (8)
|
@SteveCEvans any updates ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (3)
configs/BETAFPVH725/config.h (3)
107-107
: ESC sensor UART configuration is correct.This addresses the previous review comment requesting SERIAL_PORT_USART1.
109-120
: Conditional UART assignments are well-structured.The logic properly handles GPS, OSD display port, and serial receiver based on compile-time flags, addressing previous review feedback.
80-82
: SPI3 pin assignments are correct.The SCK, SDI, and SDO pins are properly assigned, addressing the previous transposition issue.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
configs/BETAFPVH725/config.h
(1 hunks)
🔇 Additional comments (5)
configs/BETAFPVH725/config.h (5)
1-20
: Standard GPL license header looks good.The copyright and license information is properly formatted and complete.
24-27
: Board identification is properly configured.The MCU target, board name, and manufacturer ID are correctly defined for the BETAFPVH725.
29-37
: Peripheral enable macros are appropriate for this board.The selected peripherals (ICM42688P gyro/accel, DPS310 barometer, M25P16 flash, MAX7456 OSD) are standard for modern flight controllers.
94-99
: Timer pin mappings are correctly configured.The timer assignments for motors and LED strip follow standard patterns and appear conflict-free.
122-126
: Default device configurations are sensible.Blackbox to flash, ADC-based metering, and current meter scale of 750 are appropriate defaults for this board.
f80fb08d-88c4-4df4-8f0b-2325f1c0edda
Summary by CodeRabbit
New Features
Chores