feat: monitor logs in real time #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carrotzpc
reviewed
Apr 6, 2023
| container: string; | ||
| } | ||
|
|
||
| @WebSocketGateway(8025, { path: '/bff-ws/k8s/logs' }) |
There was a problem hiding this comment.
我觉得这个应该写到oidc portal的那个bff-server里，就都可以直接用了
There was a problem hiding this comment.
按照磊哥的意思，不想在 u4a bff-server 里加太多 u4a 不相关的功能，后续日志、监控这些模块期望做成 npm 包，方便在各个业务线的 bff-server 中共享
Carrotzpc
reviewed
Apr 6, 2023
package.json
Outdated
| @@ -30,10 +30,12 @@ | |||
| "@nestjs/apollo": "^10.1.7", | |||
| "@nestjs/common": "^8.0.0", | |||
There was a problem hiding this comment.
@nestjs/common, @nestjs/platform-express 也都升级下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relate #143