Skip to content

Added support for property setter/deleter.#31

Merged
Arondit merged 3 commits intobest-doctor:masterfrom
noamkush:support-properties
Mar 20, 2025
Merged

Added support for property setter/deleter.#31
Arondit merged 3 commits intobest-doctor:masterfrom
noamkush:support-properties

Conversation

@noamkush
Copy link
Copy Markdown
Contributor

This fixes #24 and modernizes the supported python versions as I couldn't even run checks with Python 3.13 or 3.12.

Copy link
Copy Markdown

@Roman505050 Roman505050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great solution, I faced a problem today when I couldn't set the setter up properly and flake8 was swearing, even though it should be right.

@Arondit
Copy link
Copy Markdown
Contributor

Arondit commented Mar 12, 2025

@noamkush hello, thank you very much for you help. Could you please resolve merge conflict? Also i wonder why did you comment flake8-annotations-complexity==0.0.8 in requirements?
https://github.com/best-doctor/flake8-class-attributes-order/pull/31/files#diff-c9c796259f3852b51b531b79cbf07820145088d4f108fb006ab44b15f0b15934R21

@noamkush
Copy link
Copy Markdown
Contributor Author

@noamkush hello, thank you very much for you help. Could you please resolve merge conflict? Also i wonder why did you comment flake8-annotations-complexity==0.0.8 in requirements? #31 (files)

Conflicts are resolved. Regarding flake8-annotations-complexity, IIRC, there was some problem installing or running it on Python 3.13 but I couldn't reproduce this at the moment so I restored it.

@noamkush noamkush force-pushed the support-properties branch from fd8a56e to ba39611 Compare March 16, 2025 14:42
@Arondit
Copy link
Copy Markdown
Contributor

Arondit commented Mar 18, 2025

Conflicts are resolved. Regarding flake8-annotations-complexity, IIRC, there was some problem installing or running it on Python 3.13 but I couldn't reproduce this at the moment so I restored it.

I understand now, what was wrong. Yeah, we fixed this issue in flake8-annotations-complexity. Thank you for helping, i am merging it now.

@Arondit
Copy link
Copy Markdown
Contributor

Arondit commented Mar 18, 2025

@noamkush oh wait, sorry, there is also an issue. pytest-cov 6.0 requires python >3.9. You can just drop 3.8 from supported versions, it's totally OK. it should help.

@noamkush
Copy link
Copy Markdown
Contributor Author

Sure, I dropped 3.8.

@Arondit Arondit merged commit 1e88c10 into best-doctor:master Mar 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setter by property: false positive warning

3 participants