Update GraphQL queries to minimize returned attributes

berkmancenter · Aug 15, 2019 · e2d34fd · e2d34fd
1 parent da14673
commit e2d34fd
Show file tree

Hide file tree

Showing 5 changed files with 50 additions and 10 deletions.
diff --git a/app/javascript/graphql/CourseUniverse.gql b/app/javascript/graphql/CourseUniverse.gql
@@ -0,0 +1,23 @@
+query CourseUniverse(
+  $basic: String,
+  $courseLevels: [CourseLevel!],
+  $departments: [Department!],
+  $semesterRange: SemesterRange,
+) {
+    coursesConnection(
+      basic: $basic,
+      courseLevels: $courseLevels,
+      departments: $departments,
+      page: 1,
+      perPage: 5000,
+      semesterRange: $semesterRange,
+    ) {
+        edges {
+          node {
+            id
+            subjectDescription
+            title
+          }
+        }
+    }
+  }
diff --git a/app/javascript/graphql/DeptCourses.gql b/app/javascript/graphql/DeptCourses.gql
@@ -1,5 +1,3 @@
-#import "./CourseFragment.gql"
-
 query DeptCourses(
   $courseLevels: [CourseLevel!],
   $searchComponent: [Component!],
@@ -17,7 +15,8 @@ query DeptCourses(
   ) {
     edges {
       node {
-        ...Course
+        id
+        title
       }
     }
   }

diff --git a/app/javascript/graphql/KeywordComparisons.gql b/app/javascript/graphql/KeywordComparisons.gql
@@ -0,0 +1,22 @@
+query KeywordComparisons(
+  $courseLevels: [CourseLevel!],
+  $deluxeKeywords: [DeluxeKeyword!],
+  $semesterRange: SemesterRange,
+) {
+    coursesConnection(
+      courseLevels: $courseLevels,
+      deluxeKeywords: $deluxeKeywords,
+      page: 1,
+      perPage: 5000,
+      semesterRange: $semesterRange,
+    ) {
+        edges {
+          node {
+            id
+            component
+            subjectDescription
+            title
+          }
+        }
+      }
+  }
diff --git a/app/javascript/lib/explore/course-universe.js b/app/javascript/lib/explore/course-universe.js
@@ -2,7 +2,7 @@ import _ from 'lodash'
 import * as d3 from 'd3'
 import apolloClient from 'apollo'
 import COURSE_COUNTS_QUERY from '../../graphql/CourseCounts.gql'
-import COURSES_SEARCH_QUERY from '../../graphql/CoursesSearch.gql'
+import COURSES_SEARCH_QUERY from 'graphql/CourseUniverse.gql'
 import { transformSchedule } from 'lib/util'
 
 let visSize
@@ -324,8 +324,6 @@ function requestSecondData (searchText, xPos, yPos, radius) {
       basic: searchQuery,
       courseLevels: courseLevels,
       departments: enumSearch,
-      page: 1,
-      perPage: 1000,
       semesterRange: semesterRange
     }
   }).then(function (response) {

diff --git a/app/javascript/lib/explore/keyword-comparisons.js b/app/javascript/lib/explore/keyword-comparisons.js
@@ -2,7 +2,7 @@ import $ from 'jquery'
 import * as d3 from 'd3'
 import _ from 'lodash'
 import apolloClient from 'apollo'
-import COURSES_SEARCH_QUERY from '../../graphql/CoursesSearch.gql'
+import SEARCH_QUERY from 'graphql/KeywordComparisons.gql'
 import { transformSchedule } from 'lib/util'
 //  Colors
 
@@ -63,15 +63,13 @@ function requestData (searchTerm, numTerm) {
   showLoaderOverlay(true)
 
   apolloClient.query({
-    query: COURSES_SEARCH_QUERY,
+    query: SEARCH_QUERY,
     variables: {
       courseLevels: courseLevels,
       deluxeKeywords: [{
         text: searchTerm,
         applyTo: ['TITLE', 'DESCRIPTION']
       }],
-      page: 1,
-      perPage: 5000,
       semesterRange: semesterRange
     }
   }).then(function (response) {