feat(abci): move timeout_commit into FinalizeBlockResponse#22
Merged
abi87 merged 3 commits intoberachain:bera-v1.xfrom Apr 17, 2025
melekes:2655-predictable-block-times-impl
Merged
feat(abci): move timeout_commit into FinalizeBlockResponse#22abi87 merged 3 commits intoberachain:bera-v1.xfrom melekes:2655-predictable-block-times-impl
timeout_commit into FinalizeBlockResponse#22abi87 merged 3 commits intoberachain:bera-v1.xfrom
melekes:2655-predictable-block-times-impl
Conversation
…bft#3089) as `next_block_delay` ADR-115: cometbft#2966 Closes cometbft#2655 --- - [ ] ~~Tests written/updated~~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Sergio Mena <sergio@informal.systems>
alesforz
approved these changes
Feb 26, 2025
| // NOTE: when modifying, make sure to update time_iota_ms genesis parameter | ||
| // Set to 0 if you want to make progress as soon as the node has all the precommits. | ||
| // Deprecated: use `next_block_delay` in the ABCI application's `FinalizeBlockResponse`. | ||
| TimeoutCommit time.Duration `mapstructure:"timeout_commit"` |
There was a problem hiding this comment.
I would leave these docs (with the "Deprecated:..." line as well), because in internal/consensus/state.go we set it if NextBlockDelay isn't set, and we also check its value when setting skipTimeoutCommit.
So someone might still want to know what this legacy value is.
Author
There was a problem hiding this comment.
The more we diverge from the upstream v1.x, the harder it will be to keep up with it.
| # though we already have +2/3). | ||
| # Set to 0 if you want to make progress as soon as the node has all the precommits. | ||
| # Deprecated: use `next_block_delay` in the ABCI application's `FinalizeBlockResponse`. | ||
| timeout_commit = "{{ .Consensus.TimeoutCommit }}" |
There was a problem hiding this comment.
Same comment as above about the docs.
Author
|
@abi87 can we merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of cometbft#3089