chore(deps): upgrade cometBFT #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2608 +/- ##
=======================================
Coverage 58.61% 58.61%
=======================================
Files 340 340
Lines 15272 15272
Branches 20 20
=======================================
Hits 8951 8951
Misses 5652 5652
Partials 669 669 🚀 New features to boost your workflow:
|
fridrik01
reviewed
Mar 17, 2025
Dockerfile
Outdated
| @@ -18,7 +18,7 @@ | |||
| ### Stage 0 - Build Arguments ### | |||
| ####################################################### | |||
|
|
|||
| ARG GO_VERSION=1.23.5 | |||
| ARG GO_VERSION=6 | |||
There was a problem hiding this comment.
typo, thanks for spotting this. Fixed
fridrik01
reviewed
Mar 17, 2025
go.mod
Outdated
| go 1.23.5 | ||
| go 1.23.6 | ||
|
|
||
| toolchain go1.23.7 |
There was a problem hiding this comment.
whats the reason for using a newer toolchain than go version?
There was a problem hiding this comment.
Picked automagically by my machine, reverted
abi87
commented
Mar 17, 2025
| @@ -45,12 +45,12 @@ require ( | |||
| github.com/spf13/afero v1.11.0 | |||
| github.com/spf13/cast v1.7.0 | |||
| github.com/spf13/cobra v1.8.1 | |||
| github.com/spf13/pflag v1.0.5 | |||
abi87
commented
Mar 17, 2025
Comment on lines
-52
to
-53
| golang.org/x/crypto v0.32.0 | ||
| golang.org/x/sync v0.10.0 |
There was a problem hiding this comment.
fridrik01
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We upgraded CometBFT dep to pull in a few security fixes. See berachain/cometbft#25 for context.
As a consequence we upgraded go version too, to 1.23.6