-
-
Notifications
You must be signed in to change notification settings - Fork 8
feat(kitty): graphical railroad diagrams #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces graphical railroad diagram support for nvim-regexplainer, allowing users to visualize regular expressions as graphical diagrams instead of just text narratives. The implementation leverages hologram.nvim for image display in supported terminals (primarily Kitty) and includes automatic Python dependency management.
Key changes include:
- Added graphical renderer with Python-based railroad diagram generation
- Implemented hologram.nvim integration for image display in Neovim
- Created automatic dependency management system for Python packages
- Added comprehensive testing for graphical functionality
Reviewed Changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
lua/regexplainer/renderers/graphical/init.lua |
Main graphical renderer implementing railroad diagram generation and image display |
lua/regexplainer/python/railroad_generator.py |
Python script for converting regex components to railroad diagrams |
lua/regexplainer/graphics/hologram.lua |
Hologram.nvim integration for image display |
lua/regexplainer/deps/init.lua |
Automatic Python dependency management system |
lua/regexplainer/health.lua |
Health check integration for graphical dependencies |
tests/regexplainer/graphical_spec.lua |
Test suite for graphical rendering functionality |
tests/regexplainer/deps_spec.lua |
Test suite for dependency management |
plugin/nvim-regexplainer.lua |
Added cache clearing command |
README.md |
Documentation for new graphical mode features |
Comments suppressed due to low confidence (1)
lua/regexplainer/buffers/split.lua:1
- This comment indicates that debug code was removed, but the comment itself should also be removed for cleaner code.
local Shared = require 'regexplainer.buffers.shared'
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
railroads.webm