Conversation
There was a problem hiding this comment.
Pull request overview
This pull request attempts to add Spring Boot 4 support to the db-scheduler-ui project by introducing two new modules: db-scheduler-ui-starter-boot4 and example-app-boot4. The PR also includes minor updates to the parent POM (plugin versions, Lombok configuration) and modifications to the core GetTasksResponse class for null safety.
Changes:
- Added
db-scheduler-ui-starter-boot4andexample-app-boot4modules for Spring Boot 4 support - Updated Spotless plugin (2.44.3 → 3.2.1) and Google Java Format (1.17.0 → 1.28.0)
- Modified
GetTasksResponseconstructor to handle null/zero pageSize values - Added GitHub Actions workflow for testing Boot 4 modules
- Updated CLAUDE.md and .gitignore
Reviewed changes
Copilot reviewed 33 out of 34 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Added Spring Boot 4 version properties, new Boot 4 modules, updated plugin versions, added Lombok annotation processor configuration |
| db-scheduler-ui/src/main/java/no/bekk/dbscheduler/ui/model/GetTasksResponse.java | Changed pageSize parameter to Integer and added null/zero checks to prevent division by zero |
| db-scheduler-ui-starter-boot4/pom.xml | New Spring Boot 4 starter module POM with dependencies |
| db-scheduler-ui-starter-boot4/src/main/java/**/*.java | Spring Boot 4 starter auto-configuration and configuration classes (near-duplicate of Boot 3 starter) |
| example-app-boot4/pom.xml | New Spring Boot 4 example application POM |
| example-app-boot4/src/main/java/**/*.java | Example application code (complete duplicate of example-app) |
| example-app-boot4/src/test/java/**/*.java | Test classes with Boot 4-specific test utilities |
| example-app-boot4/src/main/resources/**/* | Application properties and database migration scripts (duplicates) |
| .github/workflows/tests.yml | Added workflow job for testing Boot 4 modules |
| CLAUDE.md | Added documentation file for Claude Code assistant |
| .gitignore | Added .claude directory exclusion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
example-app-boot4/src/test/java/com/github/bekk/exampleapp/SmokeTest.java
Show resolved
Hide resolved
example-app-boot4/src/test/java/com/github/bekk/exampleapp/CtxPathTest.java
Show resolved
Hide resolved
...tarter/src/main/java/no/bekk/dbscheduler/uistarter/autoconfigure/UiApiAutoConfiguration.java
Show resolved
Hide resolved
...tarter/src/main/java/no/bekk/dbscheduler/uistarter/config/DbSchedulerUiWebConfiguration.java
Show resolved
Hide resolved
example-app-boot4/src/main/java/com/github/bekk/exampleapp/config/DatabaseConfig.java
Show resolved
Hide resolved
example-app-boot4/src/main/java/com/github/bekk/exampleapp/ExampleApp.java
Show resolved
Hide resolved
89c7875 to
0039935
Compare
Collaborator
Author
|
Admittedly a lot of duplication; but the starter probably won't be updated very often, and this way we can just delete the old one once SB3-support is dropped |
0039935 to
e65a509
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Opus 4.6 did the heavy lifting; tested and ran the example app, seems to work