Fiks at man går til hovedinnhold ved klikk på knapp#350
Merged
vilderoxan merged 6 commits intomainfrom Dec 11, 2025
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PeterRydberg
reviewed
Dec 9, 2025
web/app/features/header/Header.tsx
Outdated
| @@ -11,7 +11,11 @@ interface HeaderProps { | |||
| export const Header = ({ withBreadcrumbs = true }: HeaderProps) => { | |||
Contributor
There was a problem hiding this comment.
Om withBreadcrumbs ikke brukes lenger, så kan det nok fjernes for å ikke skape forvirring.
Suggested change
| export const Header = ({ withBreadcrumbs = true }: HeaderProps) => { | |
| export const Header = () => { |
Evt. kunne man isPostYearRoute opp til der Header brukes, så sender man inn verdien til withBreadcrumbs. Men det er litt samme for meg 😊 Det er alltid litt vanskelig med conditional styling basert på hvilken side man er på
Contributor
There was a problem hiding this comment.
Jeg fjerner HeaderProps så slipper vi å sende inn noe til komponenten 🤓
vilderoxan
force-pushed
the
jump-to-main-content
branch
from
c864aef to
3c42d7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beskrivelse
Ved bruk av skjermleser popper Hopp til hovedinnhold-knappen opp, men når man klikker på den går den bare videre til Bekk-logoen (lenke til forsiden). Den gjør altså ingenting annet om man ikke hadde klikket på den.
#️⃣ Punktliste av hva som er endret: