Skip to content

Conversation

@semohr
Copy link
Contributor

@semohr semohr commented Oct 1, 2025

Migrated from flake8 to ruff for linting and formatting, updating CI workflows, adding new automation for changelog reminders, and improving contributor documentation.

The change aligns our formatting and linting for this project with beets. We still use tox for testing but removed the the flake8 part of it entirely.

@semohr semohr requested a review from JOJ0 October 1, 2025 16:16
@semohr
Copy link
Contributor Author

semohr commented Oct 1, 2025

@JOJ0 I took the liberty to fix the CI pipeline in the master directly. Since this PR is changing quite some things I don't want to decide this on my own. Would be happy to get a formal review.

Saw that you commented on some of the recent PRs. I choose you as the reviewer, hope you are fine with that :P

Copy link
Member

@JOJ0 JOJ0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing that migration to ruff! Very much appreciated! Some suggestions.

I see you ran ruff through the cocdebase already, so I trust ruff that this is fine. Moving changelog to file is great. Nobody ever found it in the past! ;-)

This is a minimum ruff configuration or and not the ruff settings copied over from beets? Right? I'm ok with that.

Should we adjust line-length to 80 as we have it in beets or better stick with the ruff default auf 88 (I prefer 88 actually :-))

@semohr semohr requested a review from JOJ0 October 5, 2025 09:54
Copy link
Member

@JOJ0 JOJ0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@semohr
Copy link
Contributor Author

semohr commented Oct 6, 2025

Do we want to merge any other PR before this? Otherwise they will need to align with the new format and rebase.

@JOJ0
Copy link
Member

JOJ0 commented Oct 7, 2025

Hmmm most old and not mergeready. Which one's were you thinking in particular?

I guess that one? #83

From my end, I can say that I went through all of them quickly and the only thing that makes sense to get merge-ready is this one: #78 (but I need to re-read all the stuff I wrote there myself to make sure there is not anything to change with the implementation in the PR. If you are bored and want to read all my research....thanks! :-P :-))

And should we maybe go thru all of those PR's again and set those to draft we are not sure about (outdated, not-ready, etc) or maybe even label them somehow?

@semohr semohr merged commit 83157ca into master Oct 11, 2025
12 checks passed
@semohr semohr deleted the flake-to-ruff branch October 11, 2025 12:11
@semohr
Copy link
Contributor Author

semohr commented Oct 11, 2025

I merged it for now. A small rebase shouldn't be that difficult ;) Better tooling should be worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants