Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP : New scripting system #115

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Spitfireap
Copy link
Contributor

Goal : Make the build process of the book more straightforward for everyone, improve the GUI, makes the code more resilient and streamlined.
Sub-Goal : implement a github action to build the book automatically.

@Spitfireap
Copy link
Contributor Author

Hi @becarpenter,
So I've worked a bit on the refactor of the code. As you wished, I've not forgotten non-cli-users. In fact, their experience got better :p.

The changes may seem consequent (especially regarding the GUI part) but it will be really easy to add new tasks to it. Furthermore, ounce I'll have imported the other scripts, the absolute diff might even be negative...

If you can test run_gui.py I would be glad. And if it looks ok for you I'll go forward and migrate the other scripts. The end goal is to have only one entry point to the jobs to make it easier for everyone to contribute as well as implementing the github action.

@becarpenter
Copy link
Owner

Thanks, again this will take me a few days due to real life...

@becarpenter
Copy link
Owner

@Spitfireap, got myself into a bit of trouble there - switched my branch to PR 115 but I didn't seem to get a new version of makeBook.py that uses the new logging module, so it crashed out. What did I miss?

(In general I like the refactoring; I grew up as an old school procedural programmer as you may have realised from my coding style, but I always meant to come back and do something like what you did. I just need to check it out in a sandbox before merging.)

@Spitfireap
Copy link
Contributor Author

Hi @becarpenter , I've been busy. So, when does it crash ? Did you launch run_gui.py or something else ?

This is to avoid module shadowing
@becarpenter
Copy link
Owner

OK, cette fois j'ai fait plus d'attention et j'ai essayé run_gui.py comme tu as proposé...
I ran it against my sandbox copy and it worked fine except for one thing. Instead of overwriting the old baked.epub, it created baked_epub.md and I had to rename it! All looks good to me.

By the way there is no good reason why the output files are baked.pdf and baked.epub; they could be book6.pdf and book6.epub. I called the whole process "bake" because Nick one day made a typo when he meant "make" and I thought it was quite funny. ("bake" = cuire ou faire du pain)

@Spitfireap
Copy link
Contributor Author

Super alors :)
Indeed I see the error. I'll correct it.
So I'll migrate all the other scripts and update the doc and lastly I'll create the github action.

The export name can sure change. Funny story for the name, tbf it didn't strike me since "baking" is also use in Blender for instance :p.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants