This repository was archived by the owner on Jan 30, 2023. It is now read-only.
Prepare to migrate to scalameta#195
Open
kitbellew wants to merge 12 commits intobeautiful-scala:masterfrom
Open
Prepare to migrate to scalameta#195kitbellew wants to merge 12 commits intobeautiful-scala:masterfrom
scalameta#195kitbellew wants to merge 12 commits intobeautiful-scala:masterfrom
Conversation
added 12 commits
July 15, 2021 22:59
For `FullDefOrDcl`, we were erroneously looking for scaladoc in all tokens, whereas the intent was for to find them before the enclosed `DefOrDcl` (for which another iteration would apply).
The scalameta parser could be used to parse complete scala source or a single statement, but not both at once. Let's make sure all our tests are parsable as full source, not single statement.
DO comes either with WHILE or FOR, and both are already counted.
If there's code on a given line, in addition to a comment, let's count it.
This includes pattern extractors, not just standalone vals.
Author
|
@mwz PTAL (easiest is to read one commit at a time, they are self-contained and normally concise). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support scala 2.13 and newer dialect, we need to migrate to
scalametaparser. This sequence of changes introduces minor fixes to mimic the post-migration behaviour.Towards #141.