Merged
Conversation
Also bump actions/checkout, bump rebar3, resolve dialyzer error, and add missing dialyzer specs.
kianmeng
commented
Oct 17, 2025
|
|
||
| -spec make_measurement(measurement()) -> measurement() | no_return(). | ||
| -spec make_measurement(measurement()) -> measurement() | error. | ||
| make_measurement(Measurement = {M, F, A}) -> |
Contributor
Author
There was a problem hiding this comment.
/tmp/telemetry_poller/src/telemetry_poller.erl:470:50: The test
{atom(), atom(), [any()]} =/=
'error' can never evaluate to 'false'
===> Warnings written to _build/default/28.1.dialyzer_warnings
kianmeng
commented
Oct 17, 2025
Comment on lines
+17
to
+32
| include: | ||
| - otp_version: "24" | ||
| rebar3_version: "3.21.0" | ||
| os: ubuntu-latest | ||
| - otp_version: "25" | ||
| rebar3_version: "3.21.0" | ||
| os: ubuntu-latest | ||
| - otp_version: "26" | ||
| rebar3_version: "3.25.1" | ||
| os: ubuntu-latest | ||
| - otp_version: "27" | ||
| rebar3_version: "3.25.1" | ||
| os: ubuntu-latest | ||
| - otp_version: "28" | ||
| rebar3_version: "3.25.1" | ||
| os: ubuntu-latest |
Contributor
Author
There was a problem hiding this comment.
josevalim
approved these changes
Oct 17, 2025
Contributor
|
💚 💙 💜 💛 ❤️ |
Contributor
Author
|
🥳 🥳 🥳 🥳 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also bump actions/checkout, bump rebar3, resolve dialyzer error, and add missing dialyzer specs.