Report system limits (atom, port, process limits)#79
Merged
josevalim merged 1 commit intobeam-telemetry:mainfrom Jun 26, 2025
Merged
Report system limits (atom, port, process limits)#79josevalim merged 1 commit intobeam-telemetry:mainfrom
josevalim merged 1 commit intobeam-telemetry:mainfrom
Conversation
Contributor
|
I am not sure we should have a separate measurement for something constant. Perhaps we can include the limits as metadata for the counts? |
Contributor
|
We could emit the limits as additional measurements in the existing system_counts event. |
studzien
force-pushed
the
report-system-counts-limits
branch
from
609a424 to
0ec48c1
Compare
Contributor
Author
|
That's fair. |
josevalim
approved these changes
Jun 26, 2025
Contributor
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's useful to report the atom, port, and process limits in addition to the current counts so that alerts can be set when we're close to reaching the limit.
This PR enhances the VM measurements by adding
vm.system_limits, which has the same measurements asvm.system_countsbut with the current limit values rather than the current counts.I'm happy to remove it from the default measurements, if it'd be better to opt in for them.