Add persistent_term built-in measurement#75
Merged
josevalim merged 1 commit intobeam-telemetry:mainfrom Mar 30, 2025
Merged
Conversation
Contributor
|
Releases before OTP 25 not officially supported anymore, so this is a fine assumption. :) |
josevalim
reviewed
Mar 29, 2025
whatyouhide
force-pushed
the
al/persistent-term
branch
from
4c368ea to
4895235
Compare
josevalim
approved these changes
Mar 30, 2025
Contributor
|
💚 💙 💜 💛 ❤️ |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54.
For now, I purposefully kept this available for all releases because, while I think this supports all the way back to OTP 19, in CI it only tests from OTP 24. If we would just bump req here to OTP 22 (
persistent_termwas introduced in OTP 21.2) then we wouldn't need to do the-if(OTP_RELEASE >= 22)or similar dance. Thoughts?