Skip to content

Conversation

@luke-lombardi
Copy link
Contributor

@luke-lombardi luke-lombardi commented Nov 1, 2025

This pull request contains changes generated by a Cursor Cloud Agent

Open in Cursor Open in Web


Summary by cubic

Fixes v2 CLIP image builds by adding auth for private base images and ensuring env vars and build secrets are correctly passed to Docker builds.

  • Bug Fixes

    • Use buildah --creds for both pull and bud when SourceImageCreds is provided (supports private registries).
    • Prevent build failures in multi-stage builds that require authenticated base images.
  • New Features

    • Render ENV lines from BuildOpts.EnvVars in generated Dockerfiles.
    • Declare BuildSecrets as ARG in Dockerfiles and pass them via --build-arg during build.
    • Apply env/secrets handling in both appendToDockerfile and RenderV2Dockerfile paths.

Written for commit fecacc4. Summary will update automatically on new commits.

@cursor
Copy link

cursor bot commented Nov 1, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@luke-lombardi luke-lombardi marked this pull request as ready for review November 1, 2025 20:08
@luke-lombardi luke-lombardi merged commit a3178a9 into ll/clipv2 Nov 1, 2025
3 checks passed
@luke-lombardi luke-lombardi deleted the cursor/fix-v2-clip-image-authentication-and-env-issues-e9ce branch November 1, 2025 20:08
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants