Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for perform_dc not working #44

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Fix for perform_dc not working #44

merged 1 commit into from
Jul 1, 2021

Conversation

thiloshon
Copy link
Collaborator

Status

READY

Fix for #37

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality in package or package system to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • RCMD
  • Package Installation from Github
  • Travis / Github Workflow
  • Unit Tests
  • Shiny Tests
  • Manual Tests

Checklist:

  • I have updated DESCRIPTION with date, version, dependencies
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors in the package
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Todos

  • Tests
  • Documentation

Related PRs

List related PRs against other branches:

branch PR
other_pr_production link
other_pr_master link

Environment Details

R Version:
OS:

Where should a reviewer start?

Manual testing steps?

Screenshots

Sorry, something went wrong.

@thiloshon thiloshon merged commit 67fad06 into bd-R:dev Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant