Filtering action crashes the app

[tom-gu]

Console error:

Filtering functions in bdchecks:
https://github.com/bd-R/bdchecks/blob/dev/R/filter.R

Brunches:

bdchecks>>dev | bdchecks.app>>dev

[rahulchauhan049]

After spending a few hours, I believe the issue occurs because bdchecks::perform_dc (https://github.com/bd-R/bdchecks.app/blob/master/R/mod_perform_checks.R#L82) return error when data contain fields with time stamp like dateIdentified or eventDate, etc.

Error this function return is: Error in as.POSIXlt.character(x, tz, ...) :
character string is not in a standard unambiguous format

[tom-gu]

Hi Rahul,

The date error is a known one. I hoped we've already purged it, but it still lurks around. @Martis6 will take care of it (bd-R/bdchecks#27).

However, the filtering function gives an error even when performing bug-free checks.

@rahulchauhan049 or @thiloshon can you please exactly describe us the input coming from the Shiny app (i.e., cell_selected from https://github.com/bd-R/bdchecks/blob/dev/R/filter.R). That way @Martis6 can check it from his end and even build a unit testing.

[tom-gu]

@Martis6
The cell_selected input (i.e., input$summaryTable_cells_selected created via the shiny app) is a simple matrix.
The 1st col of the matrix denoting row number (notice that a row/data-check without a selection will not be shown), and the 2nd col denoting the col that the user chose to filter by:

• 2 is for passed
• 3 is for failed
• 4 is for missing

Example:

For the following table selection:

This is the matrix:

This matrix is also attached (RData file):
summaryTable_cells_selected.zip

[tom-gu]

@Martis6 @thiloshon @rahulchauhan049
The problem is simply a missing data argument (😭) in:

bdchecks.app/R/mod_perform_checks.R

Line 100 in 8cce435

clean_data <<- bdchecks:::dc_filter(check_result, summary_filter)

We can fix the issue by adding:
clean_data <<- bdchecks:::dc_filter(user_data, check_result, summary_filter)
Or
clean_data <<- bdchecks:::dc_filter(bdutilities::return_core(user_data), check_result, summary_filter)

Which one is better, and why?

Lesson: To improve our function's defensive programming 🏆 bd-R/bdchecks#28

[thiloshon]

return_core is better as we can't predict when user_data is reactive or not. return_core always returns the core object if a reactive value is passed.