Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenant UI 2.0 protocol changes #1280

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Tenant UI 2.0 protocol changes #1280

merged 3 commits into from
Jul 29, 2024

Conversation

loneil
Copy link
Contributor

@loneil loneil commented Jul 26, 2024

Update Tenant UI credential/proof/etc protocols that can are called through the interface to use 2.0 protocols.
Update unit tests, some other Typescript refactors. Dependency updates.

Tested connecting OOBs, issuing Traction Tenant to Traction Tenant, accepting/denying revoking credentials as issuer and holder, sending pres reqs etc. Tested out with BC Wallet as well.

@loneil loneil force-pushed the feature/v2Issuance branch 2 times, most recently from 195dad4 to a722426 Compare July 26, 2024 02:59
@loneil loneil marked this pull request as ready for review July 26, 2024 20:52
@loneil loneil changed the title 2.0 protocol changes Tenant UI 2.0 protocol changes Jul 26, 2024
@loneil loneil force-pushed the feature/v2Issuance branch from aab9cfe to 9402236 Compare July 26, 2024 21:46
loneil added 3 commits July 26, 2024 15:23
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
@loneil loneil force-pushed the feature/v2Issuance branch from 9402236 to 88126a2 Compare July 26, 2024 22:24
@loneil loneil requested review from esune, amanji, jamshale and Gavinok July 26, 2024 22:37
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Only wondering if we should add something to the backlog and/or TODOs in the code to handle presentation exchanges that are not of type indy (i.e.: dif) in the future.

@loneil
Copy link
Contributor Author

loneil commented Jul 29, 2024

👍🏻

Only wondering if we should add something to the backlog and/or TODOs in the code to handle presentation exchanges that are not of type indy (i.e.: dif) in the future.

Right, probably some other UI considerations around using non Indy through the interface. Can track here #1284

@loneil loneil merged commit f7e28b6 into main Jul 29, 2024
14 checks passed
@loneil loneil deleted the feature/v2Issuance branch August 6, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants