Move all project configuration to pyproject.toml #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove requirements.txt, requirements-doc.txt, requirements-dev.txt, and setup.cfg and replace them with equivalent content in pyproject.toml. Currently flake8 configuration is missing -- this was configured in setup.cfg and cannot currently be configured in pyproject.toml (see PyCQA/flake8#234 ).
This configuration was previously in setup.cfg, but now that all other project configuration has been moved to pyproject.toml, it's safer to remove setup.cfg (since it might affect pip behaviour) and use a dedicated .flake8 file for flake8 configuration.
They were trying to read requirements files which no longer exist.
Development and doc dependencies weren't being installed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 30 30
Lines 1454 1454
=======================================
Hits 1453 1453
Misses 1 1 ☔ View full report in Codecov by Sentry. |
thomasstorm
approved these changes
Mar 20, 2024
forman
reviewed
Mar 20, 2024
Add an issue number per PR #89 review. Co-authored-by: Norman Fomferra <[email protected]>
TejasMorbagal
approved these changes
Mar 21, 2024
TonioF
approved these changes
Mar 22, 2024
@TonioF It's a workaround for a bug in pycodestyle, which is used by flake8. I've added a comment to the .flake8 file to explain it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #88 .
Checklist (strike out non-applicable):
CHANGES.mdCHANGES.md* [ ] Added docstrings and API docs for any new/modified user-facing classes and functionsn/adocs/** [ ] Unit-tests adapted/added for changes/featuresn/a