Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New configuration setting slice_source_kwargs #84

Merged
merged 10 commits into from
Mar 19, 2024

Conversation

forman
Copy link
Member

@forman forman commented Mar 18, 2024

Addresses #82. To close, see #86.

Checklist (strike out non-applicable):

  • Changes documented in CHANGES.md
  • Related issue exists and is referred to in the PR description and CHANGES.md
  • Added docstrings and API docs for any new/modified user-facing classes and functions
  • Changes/features documented in docs/*
  • Unit-tests adapted/added for changes/features
  • Test coverage remains or increases (target 100%)

@forman forman added the enhancement New feature or request label Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (8dc8167) to head (9835d42).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          30       30           
  Lines        1436     1443    +7     
=======================================
+ Hits         1435     1442    +7     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forman forman changed the title New slice_source_kwargs setting New configuration setting slice_source_kwargs Mar 18, 2024
@forman forman self-assigned this Mar 18, 2024
@forman forman marked this pull request as ready for review March 19, 2024 05:29
@forman forman requested a review from thomasstorm March 19, 2024 09:08
Copy link
Contributor

@thomasstorm thomasstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comment on guide.md

forman and others added 2 commits March 19, 2024 10:53
@forman forman requested a review from thomasstorm March 19, 2024 09:59
@forman forman merged commit db3ab06 into main Mar 19, 2024
5 checks passed
@forman forman deleted the forman-82-slice_source_kwargs branch March 19, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants