Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Config class out of Context #75

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

forman
Copy link
Member

@forman forman commented Mar 7, 2024

Internal refactoring: Extracted Config class out of Context and made available via new Context.config: Config property. The change concerns any usages of the ctx: Context argument passed to user slice factories.

Closes #74

Checklist (strike out non-applicable):

  • Changes documented in CHANGES.md
  • Related issue exists and is referred to in the PR description and CHANGES.md
  • Added docstrings and API docs for any new/modified user-facing classes and functions
  • Changes/features documented in docs/*
  • Unit-tests adapted/added for changes/features
  • Test coverage remains or increases (target 100%)

@forman forman self-assigned this Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (249b7e8) to head (5cbcb7d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          26       28    +2     
  Lines        1396     1426   +30     
=======================================
+ Hits         1395     1425   +30     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forman forman marked this pull request as ready for review March 7, 2024 18:02
@forman forman requested a review from pont-us March 7, 2024 18:02
Copy link
Member

@pont-us pont-us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion.

@forman forman merged commit 9bf3160 into main Mar 11, 2024
5 checks passed
@forman forman deleted the forman-74-refactor_config branch March 11, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make config have type Config instead of dict
2 participants