Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration setting force_new #73

Merged
merged 8 commits into from
Mar 7, 2024
Merged

Conversation

forman
Copy link
Member

@forman forman commented Mar 7, 2024

Added configuration setting force_new, which forces creation of a new target dataset. An existing target dataset (and its lock) will be permanently deleted before appending of slice datasets begins.

Closes #72

Checklist (strike out non-applicable):

  • Changes documented in CHANGES.md
  • Related issue exists and is referred to in the PR description and CHANGES.md
  • Added docstrings and API docs for any new/modified user-facing classes and functions
  • Changes/features documented in docs/*
  • Unit-tests adapted/added for changes/features
  • Test coverage remains or increases (target 100%)

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (2b56f1f) to head (9741c43).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   99.85%   99.92%   +0.07%     
==========================================
  Files          26       26              
  Lines        1372     1396      +24     
==========================================
+ Hits         1370     1395      +25     
+ Misses          2        1       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forman forman marked this pull request as ready for review March 7, 2024 13:51
@forman forman requested a review from thomasstorm March 7, 2024 13:57
Copy link
Contributor

@thomasstorm thomasstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions, include or drop as you wish. Looks like a good feature!

forman and others added 4 commits March 7, 2024 15:42
Co-authored-by: Thomas Storm <[email protected]>
Co-authored-by: Thomas Storm <[email protected]>
Co-authored-by: Thomas Storm <[email protected]>
Co-authored-by: Thomas Storm <[email protected]>
@forman forman merged commit 249b7e8 into main Mar 7, 2024
5 checks passed
@forman forman deleted the forman-72-replace_option branch March 7, 2024 15:10
@forman forman mentioned this pull request Mar 8, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for replacing target
2 participants