Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hyphen in config names #61

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Conversation

forman
Copy link
Member

@forman forman commented Feb 21, 2025

Closes #60

Checklist (strike out non-applicable):

  • Changes documented in CHANGES.md
  • Related issue exists and is referred to in the PR description and CHANGES.md
  • Added docstrings and API docs for any new/modified user-facing classes and functions
  • Changes/features documented in docs/*
  • Unit-tests adapted/added for changes/features
  • Test coverage remains or increases (target 100%)

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.46%. Comparing base (79f497e) to head (84ee85d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   99.46%   99.46%   -0.01%     
==========================================
  Files          67       67              
  Lines        2806     2805       -1     
  Branches      412      412              
==========================================
- Hits         2791     2790       -1     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forman forman marked this pull request as ready for review February 21, 2025 15:13
@forman forman merged commit 8c0f848 into main Feb 21, 2025
6 checks passed
@forman forman deleted the forman-60-allow_hyphen_in_config_names branch February 21, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for hyphens in default configuration names
1 participant