-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event and click tracking to bullet list link #9654
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a question, does this work need an a11y swarm?
Not sure. Since this is just adding tracking and isn't changing how the data is displayed I wouldn't think so, but with this bug possibly being related to tracking it might need one. |
I am not sure if it is worth to be honest. If it is worth, I would suggest doing it after the bug is resolved. At the same time this might causes delays :/. Or we might discover that the bug was isolated to a single component. Either way it might be better to ask in stand-up or to @greenc05 on Monday. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Resolves #9731
Overall change:
Adds click and view tracking to bulleted lists that have links using the index.
Code changes:
Test pages
Bullet list (no links)
http://localhost:7080/arabic/23298105
Bullet list (links, single block)
http://localhost:7080/amharic/news-53260525
http://localhost:7080/portuguese/brasil-59057279
Bullet list (links, multiple blocks)
http://localhost:7080/afaanoromoo/oduu-53268428
http://localhost:7080/pidgin/tori-23463103
http://localhost:7080/azeri/international-53242449
http://localhost:7080/igbo/afirika-23252735
cross-team
label to this PR if it requires visibility across World Service teamsTesting:
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive
)