Skip to content

WORLDSERVICE-237 - Clean up isWebP unused variables #12605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amoore108 merged 8 commits into from
Apr 7, 2025
Merged

WORLDSERVICE-237 - Clean up isWebP unused variables #12605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
617258d
Merge branch 'latest' of github.com:bbc/simorgh into latest
louisearchibald Mar 19, 2025
f417c4f
Merge branch 'latest' of github.com:bbc/simorgh into latest
louisearchibald Mar 25, 2025
b57314e
Merge branch 'latest' of github.com:bbc/simorgh into latest
louisearchibald Apr 3, 2025
f9b6614
remove isWebP variables
louisearchibald Apr 4, 2025
faba49e
Merge branch 'latest' into WORLDSERVICE-237-clean-up-iswebp-unused-va…
louisearchibald Apr 4, 2025
affc433
reinstate arrow function
louisearchibald Apr 4, 2025
81c81b6
Merge branch 'WORLDSERVICE-237-clean-up-iswebp-unused-variables' of g…
louisearchibald Apr 4, 2025
c250d44
Merge branch 'latest' into WORLDSERVICE-237-clean-up-iswebp-unused-va…
louisearchibald Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/app/components/MediaLoader/utils/buildPlaceholderConfig/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ export default ({
const placeholderSrcset = getPlaceholderSrcSet({
originCode: placeholderImageOriginCode,
locator: placeholderImageLocator,
isWebP: true,
});

return {
Expand Down
6 changes: 2 additions & 4 deletions src/app/lib/utilities/srcSet/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,14 @@ export const createSrcsets = ({
}

// eslint-disable-next-line prefer-const
let [primarySrcset, fallbackSrcset] = [true, false].map(isWebP =>
let [primarySrcset, fallbackSrcset] = [true, false].map(() =>
requiredResolutions
.map(
resolution =>
`${buildIChefUrl({
originCode,
locator,
resolution,
isWebP,
})} ${resolution}w`,
)
.join(', '),
Expand All @@ -68,15 +67,14 @@ export const createSrcsets = ({
fallbackMimeType: getMimeType(fallbackSrcset),
};
};
export const getPlaceholderSrcSet = ({ originCode, locator, isWebP }) => {
export const getPlaceholderSrcSet = ({ originCode, locator }) => {
if (!originCode || !locator) return '';
return DEFAULT_RESOLUTIONS.map(
resolution =>
`${buildIChefUrl({
originCode,
locator,
resolution,
isWebP,
})} ${resolution}w`,
).join(', ');
};
Loading