WORLDSERVICE-649 Rename cypress test file #12600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilysaffron
changed the title
cypress/e2e/specialFeatures/liteSiteWeight/helpers/getTotalPageSize.js
Outdated
Show resolved
Hide resolved
karinathomasbbc
approved these changes
Apr 4, 2025
| // eslint-disable-next-line cypress/unsafe-to-chain-command | ||
| return cy | ||
| .wrap(requests) | ||
| .each(({ url, contentLength }) => { | ||
| if (contentLength) { | ||
| requestSizes.push({ url, size: contentLength }); |
There was a problem hiding this comment.
Weirdly not seeing the ATI requests listed in the output (I was getting them locally when we first did the curl / content-length stuff...)
There was a problem hiding this comment.
Yeaaa , it might be a timing thing? as those are fired off after the page load, so maybe they're not getting fired off fast enough to be captured in the requests sometimes - think maube this is fine as they're not technically part of the inital data a user has to download?
27 tasks
HarveyPeachey
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: WORLDSERVICE-649
Summary
rename test file
ws-nextjs-app/cypress/e2e/specialFeatures/liteSiteWeight/index.js -> ws-nextjs-app/cypress/e2e/specialFeatures/liteSiteWeight/index.cy.tsso it can runalso adds some new logging for the cypress test
Code changes
Developer Checklist
Testing
Ready-For-Test, Local)Ready-For-Test, Test)Ready-For-Test, Preview)Ready-For-Test, Live)Additional Testing Steps
Useful Links