Cypress tests for service worker #12589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karinathomasbbc
commented
Apr 1, 2025
|
|
||
| const testSuites = [ | ||
| { | ||
| path: '/pidgin/articles/czje40pxkypo?renderer_env=live', |
There was a problem hiding this comment.
Do we need more examples of other page types / services?
There was a problem hiding this comment.
Is it likely to work on one page/ service and not other pages/services?
There was a problem hiding this comment.
It should work the same for all of them. I think I might add a couple of serbian examples lat + cyr - just to make sure the routing works as expected? We could focus on articles first, but it should work for other page types too, which use the cached libraries.
Also, because these tests live in the Express app, there are no tests for live (or any other NextJS rendered) pages - but this can perhaps come later?
Isabella-Mitchell
approved these changes
Apr 2, 2025
amoore108
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cypress tests to test service worker caching functionality
Code changes
specialFeaturessuiteDeveloper Checklist - N/A
Testing
Additional Testing Steps
Ensure that the service worker tests pass when run against different environments
CYPRESS_APP_ENV=test yarn cypress run --spec './cypress/e2e/specialFeatures/serviceWorker/index.cy.js'CYPRESS_APP_ENV=live yarn cypress run --spec './cypress/e2e/specialFeatures/serviceWorker/index.cy.js'Useful Links