Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAM1-446: Live Page Header - Title & Description UX #10901

Merged
merged 21 commits into from
Jun 27, 2023

Conversation

Isabella-Mitchell
Copy link
Contributor

@Isabella-Mitchell Isabella-Mitchell commented Jun 16, 2023

Resolves JIRA WSTEAM1-446

Overall changes

  • Add UX styling and A11y to Live Page Header
  • Note this PR only covers the Title and (optional) Description fields and (optional) live label (without SVG/ pulse).

Code changes

  • Create Header component with styles.
  • Add Header component to Storybook
  • Add unit tests
  • Add new colours that are missing from our ThemeProvider

Notes for follow up PRs

  • I have used CSS Grid and media queries to manage the layout. The following should be added to the css styles of the 'Last updated...' timestamp to make it line up beneath the description on larger device sizes.
    [mq.GROUP_4_MIN_WIDTH]: {
    gridColumn: '5 / span 8',
    },
    Alternatively, they can apply the layoutWithLiveLabel css

Testing

  • Check all unit tests pass
  • A11y swarm to be completed once the Live Label ticket has been code reviewed and promoted on the BFF/ merged into this branch.
  • I have checked with Android TalkBack (to confirm this Talkback bug doesn't happen with spans nested in the Heading component), iPhone voiceover and Mac voiceover.

Storybook Preview links:

Helpful Links

Screen Reader UX - https://paper.dropbox.com/doc/WS-Live-page-Screen-reader-UX--B6TFvTNBwrjdQ20dOGXf0inXAg-8qm1UHDGVMhv5Qj9Q2mbi
Live page Accessibility Acceptance Criteria https://paper.dropbox.com/doc/Live-page-Accessibility-Acceptance-Criteria--B6SIWyI1GdxqKC5Me1s1rQCZAg-KZQODmAf9tvodUlxsAVnA
Designs - https://www.figma.com/file/ozHsWG5R9tETw6lBOU740V/Live-mvp-header---handover?type=design&node-id=402-36825

Coding Standards

Repository use guidelines

@Isabella-Mitchell Isabella-Mitchell changed the title Wsteam1 446 live page header WSTEAM1-446: Live Page Header - Title & Description UX Jun 16, 2023
Copy link
Contributor

@amoore108 amoore108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice job!

@Isabella-Mitchell Isabella-Mitchell marked this pull request as ready for review June 20, 2023 13:36
@Isabella-Mitchell Isabella-Mitchell added a11y-swarm An a11y swarm (clarify dev or full team in the desc) needs to be carried out before moving to test Do not merge labels Jun 20, 2023
@greenc05
Copy link

greenc05 commented Jun 20, 2023

Impeccable as usual @Isabella-Mitchell 😄

@Isabella-Mitchell Isabella-Mitchell removed a11y-swarm An a11y swarm (clarify dev or full team in the desc) needs to be carried out before moving to test Do not merge labels Jun 27, 2023
@Isabella-Mitchell Isabella-Mitchell merged commit d5d9db4 into latest Jun 27, 2023
@Isabella-Mitchell Isabella-Mitchell deleted the wsteam1-446-live-page-header branch June 27, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants