-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSTEAM1-446: Live Page Header - Title & Description UX #10901
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isabella-Mitchell
changed the title
Wsteam1 446 live page header
WSTEAM1-446: Live Page Header - Title & Description UX
Jun 16, 2023
amoore108
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, nice job!
greenc05
reviewed
Jun 19, 2023
ws-nextjs-app/pages/[service]/new_live/[id]/Header/index.test.tsx
Outdated
Show resolved
Hide resolved
greenc05
reviewed
Jun 19, 2023
Isabella-Mitchell
added
a11y-swarm
An a11y swarm (clarify dev or full team in the desc) needs to be carried out before moving to test
Do not merge
labels
Jun 20, 2023
shayneahchoon
approved these changes
Jun 20, 2023
Impeccable as usual @Isabella-Mitchell 😄 |
WSTEAM1-447 - Conditionally Render Live Label
Isabella-Mitchell
removed
a11y-swarm
An a11y swarm (clarify dev or full team in the desc) needs to be carried out before moving to test
Do not merge
labels
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA WSTEAM1-446
Overall changes
Code changes
Notes for follow up PRs
[mq.GROUP_4_MIN_WIDTH]: {
gridColumn: '5 / span 8',
},
Alternatively, they can apply the layoutWithLiveLabel css
Testing
Storybook Preview links:
Helpful Links
Screen Reader UX - https://paper.dropbox.com/doc/WS-Live-page-Screen-reader-UX--B6TFvTNBwrjdQ20dOGXf0inXAg-8qm1UHDGVMhv5Qj9Q2mbi
Live page Accessibility Acceptance Criteria https://paper.dropbox.com/doc/Live-page-Accessibility-Acceptance-Criteria--B6SIWyI1GdxqKC5Me1s1rQCZAg-KZQODmAf9tvodUlxsAVnA
Designs - https://www.figma.com/file/ozHsWG5R9tETw6lBOU740V/Live-mvp-header---handover?type=design&node-id=402-36825
Coding Standards
Repository use guidelines