tests pass and updates to docs after first pdf export read

Author: bbartling

open_fdd/platform/drivers/bacnet.py

@@ -353,7 +353,9 @@ async def scrape_bacnet_from_csv(
         }
 
     logger.info("BACnet scrape via RPC: %s (site=%s)", server_url, site_id)
-    return await _scrape_via_rpc(csv_path, site_id, config_rows, by_device, server_url=server_url)
+    return await _scrape_via_rpc(
+        csv_path, site_id, config_rows, by_device, server_url=server_url
+    )
 
 
 def run_bacnet_scrape(

open_fdd/tests/engine/test_weather_rules.py

@@ -1,10 +1,20 @@
 """Tests for weather fault rules."""
 
+from pathlib import Path
+
 import pandas as pd
 import pytest
 
 from open_fdd.engine import RuleRunner
-from pathlib import Path
+
+# Weather rules use Brick class names; test DataFrame uses Open-Meteo column names.
+# Pass this column_map so the runner resolves Brick -> actual df columns.
+WEATHER_COLUMN_MAP = {
+    "Humidity_Sensor": "rh_pct",
+    "Wind_Gust_Speed_Sensor": "gust_mph",
+    "Wind_Speed_Sensor": "wind_mph",
+    "Outside_Air_Temperature_Sensor": "temp_f",
+}
 
 
 @pytest.fixture
@@ -43,6 +53,7 @@ def test_weather_rules_load(weather_df):
             "tolerance": 0.2,
             "window": 6,
         },
+        column_map=WEATHER_COLUMN_MAP,
         skip_missing_columns=True,
     )
     assert "fault_rh_out_of_range" in result.columns
@@ -59,11 +70,19 @@ def test_weather_rh_out_of_range(weather_df):
         r for r in runner._rules if r.get("name") == "weather_rh_out_of_range"
     ]
 
-    result = runner.run(weather_df, params={"rh_min": 0, "rh_max": 100})
+    result = runner.run(
+        weather_df,
+        params={"rh_min": 0, "rh_max": 100},
+        column_map=WEATHER_COLUMN_MAP,
+    )
     # All rh in 50-86, within [0,100]
     assert result["fault_rh_out_of_range"].sum() == 0
 
-    result2 = runner.run(weather_df, params={"rh_min": 70, "rh_max": 85})
+    result2 = runner.run(
+        weather_df,
+        params={"rh_min": 70, "rh_max": 85},
+        column_map=WEATHER_COLUMN_MAP,
+    )
     # Some rh < 70 or > 85
     assert result2["fault_rh_out_of_range"].sum() > 0
 
@@ -81,5 +100,5 @@ def test_weather_gust_lt_wind(weather_df):
         r for r in runner._rules if r.get("name") == "weather_gust_lt_wind"
     ]
 
-    result = runner.run(df)
+    result = runner.run(df, column_map=WEATHER_COLUMN_MAP)
     assert result["fault_gust_lt_wind"].sum() >= 2

tools/run_bacnet_scrape.py

@@ -108,7 +108,9 @@ def main() -> int:
                     log.warning("Gateway CSV not found: %s", csv_path)
                     continue
                 try:
-                    result = run_bacnet_scrape(csv_path, site_id, "bacnet", server_url=url)
+                    result = run_bacnet_scrape(
+                        csv_path, site_id, "bacnet", server_url=url
+                    )
                 except Exception as e:
                     log.exception("Gateway %s failed: %s", site_id, e)
                     continue
@@ -162,7 +164,9 @@ def main() -> int:
         )
         while True:
             try:
-                result = run_bacnet_scrape(csv_path, site_id, server_url=settings.bacnet_server_url)
+                result = run_bacnet_scrape(
+                    csv_path, site_id, server_url=settings.bacnet_server_url
+                )
                 log.info(
                     "Scrape cycle: %d rows, %d points, %d errors",
                     result["rows_inserted"],
@@ -173,7 +177,9 @@ def main() -> int:
                 log.exception("Scrape failed: %s", e)
             time.sleep(interval_sec)
     else:
-        result = run_bacnet_scrape(csv_path, site_id, server_url=settings.bacnet_server_url)
+        result = run_bacnet_scrape(
+            csv_path, site_id, server_url=settings.bacnet_server_url
+        )
         if result["errors"] and result["rows_inserted"] == 0:
             for e in result["errors"]:
                 log.error("%s", e)