Skip to content

crate_universe github actions no longer run on forks #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2021
Merged

crate_universe github actions no longer run on forks #685

merged 1 commit into from
Apr 8, 2021

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Apr 8, 2021

This github action should not run on forks. This prevents each job from being kicked off in cases where users open a PR from their fork if they make changes on their main branch.

@google-cla google-cla bot added the cla: yes label Apr 8, 2021
@dfreese
Copy link
Collaborator

dfreese commented Apr 8, 2021

Based on the discussion in #680, can we remove the commit logic for now?

@UebelAndre
Copy link
Collaborator Author

I'm a bit short on time today so this is all I'm able to manage. This should be merged to prevent undesirable behavior in other PRs.

@illicitonion illicitonion merged commit 81abea6 into bazelbuild:main Apr 8, 2021
@illicitonion
Copy link
Collaborator

Based on the discussion in #680, can we remove the commit logic for now?

Raised #686 to do this while we work out a plan :)

yagehu pushed a commit to yagehu/rules_rust that referenced this pull request Apr 23, 2021
This github action should not run on forks. This prevents each job from being kicked off in cases where users open a PR from their fork if they make changes on their `main` branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants