Skip to content

Updated cargo-raze outputs #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 31, 2020
Merged

Updated cargo-raze outputs #542

merged 3 commits into from
Dec 31, 2020

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Dec 27, 2020

Regenerated cargo-raze outputs using version 0.8.0. A clearer impact of the changes can be seen in 2b2f87c

This change is intended to reduce the footprint of #500

@google-cla google-cla bot added the cla: yes label Dec 27, 2020
@UebelAndre
Copy link
Collaborator Author

UebelAndre commented Dec 27, 2020

It's worth noting that I had to regenerate the wasm-bindgen lockfile and set gen_buildrs = true for libc. Users will otherwise experience the following error:

INFO: From Compiling Rust lib socket2 v0.3.19 (7 files) [for host]:
error: cannot construct `in6_addr` with struct literal syntax due to inaccessible fields
   --> external/rules_rust_wasm_bindgen__socket2__0_3_19/src/sockaddr.rs:244:25
    |
244 |         let sin6_addr = in6_addr {
    |                         ^^^^^^^^

error: aborting due to previous error

This appears to be related to an issue opened here: rust-lang/socket2#130

relevant code: #542 (comment)

@UebelAndre UebelAndre marked this pull request as ready for review December 27, 2020 15:58
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illicitonion illicitonion merged commit 78ac316 into bazelbuild:master Dec 31, 2020
@UebelAndre UebelAndre deleted the raze branch December 31, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants