Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build scripts now receive the files and default runfiles of their explicitly declared tools at the execution paths used by
build_script_env. A compiler incoming transition can configure the script's runfiles differently from the action'stools; relying on the former then leaves the expanded tool path missing.The regression models that transition and checks both the exact action-input paths and sandboxed execution of a generated tool with a runtime file. It also retains ordinary public-macro coverage. The transitioned fixture fails without the fix and all four tests pass with it.
Fixes #4297.
Validation:
bazel test //cargo/tests/cargo_build_script/tool_inputs:all(4 tests passed); formatting and whitespace checks passed.