Conversation
This was referenced Sep 24, 2026
jrandolf
force-pushed
the
codex/upstream-build-script-lints
branch
2 times, most recently
from
September 27, 2026 21:33
9b01eeb to
8b61564
Compare
UebelAndre
approved these changes
Sep 28, 2026
UebelAndre
left a comment
Collaborator
There was a problem hiding this comment.
Thank you! Could you also add a test that shows lint_config applying to a proc-macro (unless we already have a test for that then it's fine)
Contributor
Author
|
Added All five tests and the real fixture builds now pass locally on macOS arm64 with Bazel 9.2.0 at 2774489. |
jrandolf
force-pushed
the
codex/upstream-build-script-lints
branch
from
September 28, 2026 19:15
2774489 to
bfd2845
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
cargo_build_scriptto accept an explicitlint_configand forward it to build-script compilation. Explicit rustc lints also apply in execution configurations, so build scripts and procedural macros honor the configuration attached to them.Analysis coverage checks the configured rustc lint and check-cfg flags on a library, a build script, and a proc-macro in both target and execution configurations. Existing Clippy and rustdoc cases remain in the suite.
Validation: all five tests and the real fixture builds pass locally on macOS arm64 with Bazel 9.2.0 at bfd2845 (
bazel test //test/unit/lint_flags:all). The new proc-macro case checks both target and execution configurations. Formatting checks also pass.Closes #3486.