-
Notifications
You must be signed in to change notification settings - Fork 481
Fix issues causing the Rustc
process wrapper to be built non-determ…
#2216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
@ECHO OFF | ||
SETLOCAL enabledelayedexpansion | ||
|
||
SET command=%* | ||
|
||
:: Resolve the `${pwd}` placeholders | ||
SET command=!command:${pwd}=%CD%! | ||
|
||
:: Strip out the leading `--` argument. | ||
SET command=!command:~3! | ||
|
||
:: Find the rustc.exe argument and sanitize it's path | ||
for %%A in (%*) do ( | ||
SET arg=%%~A | ||
if "!arg:~-9!"=="rustc.exe" ( | ||
SET sanitized=!arg:/=\! | ||
|
||
SET command=!sanitized! !command:%%~A=! | ||
goto :break | ||
) | ||
) | ||
|
||
:break | ||
|
||
%command% | ||
|
||
:: Capture the exit code of rustc.exe | ||
SET exit_code=!errorlevel! | ||
|
||
:: Exit with the same exit code | ||
EXIT /b %exit_code% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
#!/usr/bin/env bash | ||
|
||
set -euo pipefail | ||
|
||
# Skip the first argument which is expected to be `--` | ||
shift | ||
|
||
args=() | ||
|
||
for arg in "$@"; do | ||
# Check if the argument contains "${PWD}" and replace it with the actual value of PWD | ||
if [[ "${arg}" == *'${pwd}'* ]]; then | ||
arg="${arg//\$\{pwd\}/$PWD}" | ||
fi | ||
args+=("${arg}") | ||
done | ||
|
||
exec "${args[@]}" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unclear if this actually results in deterministic outputs. I do not have a windows machine to verify.