Skip to content

Disable coverage checks for min Bazel version jobs #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

UebelAndre
Copy link
Collaborator

@scentini
Copy link
Collaborator

Should we consider bumping up the min supported Bazel to 6.3?
#2072 is also a change that fails on 6.0, albeit for that one we can ask to make it compatible with both 6.0 and 6.3.

@UebelAndre
Copy link
Collaborator Author

UebelAndre commented Jul 27, 2023

Should we consider bumping up the min supported Bazel to 6.3? #2072 is also a change that fails on 6.0, albeit for that one we can ask to make it compatible with both 6.0 and 6.3.

I'm actually not sure this should be merged. I saw here a job that didn't produce any coverage and it ran on 6.3.0. This issue feels like an issue in Bazel itself so I opened bazelbuild/bazel#19098. I definitely don't want CI to be flaking but I highly value the ability to generate coverage reports for Rust code and don't want this to regress.

@UebelAndre UebelAndre closed this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants