-
Notifications
You must be signed in to change notification settings - Fork 481
Added CI for minimum supported Rust version #1720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rust Versiosn and associated repository errors1.58.0
|
platform: ubuntu2004 | ||
shell_commands: *min_rust_version_shell_commands | ||
build_targets: *single_rust_channel_targets | ||
test_targets: *single_rust_channel_targets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I think we should be testing the rules all together, there might be value in having more granular testing for this since the current failure on 1.58.0
is a failure in a transitive crate_universe dependency. Open to suggestions on how this should be structured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scentini @krasimirgg any thoughts here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna merge for now. The jobs can be updated in a separate change.
This change adds jobs to CI that test a minimum supported Rust version. This job is intended to inform contributors when a change is being made that would force users to upgrade their Rust version.
closes #828