Add support to inject cc_feature into legacy toolchains #525
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a parameter to unix cc_toolchain_config and windows cc_toolchain_config to be able to inject a cc_feature. This allows a user to inject a feature (for example for custom warnings) without having to reimplement the full toolchain. Resolves bazelbuild#517
limdor
requested review from
armandomontanez,
c-mita,
comius,
hvadehra,
pzembrod and
trybka
as code owners
This is required to be able to use it in the unix and windows toolchains that get generated in a separate repository.
Contributor
Author
|
I added to 0538f26 to see if the rest of the tests were passing. I believe that this is not wanted but I would ask for advice. The problem we have here is that the bzl file ends up in a generated repository. AFAIK there is no way or it is not a good practice to allow visibility to a specific named repository. |
Collaborator
|
Re: visibility I'd expect adding |
limdor
force-pushed
the
inject_features_support
branch
from
9a59372 to
eeb2411
Compare
Contributor
Author
|
@armandomontanez it does not work. It does not seem to be allowed to use the @ notation Error in visibility: invalid package name '@local_config_cc//...': must start with '//' or be 'public' or 'private' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a parameter to unix cc_toolchain_config and windows cc_toolchain_config to be able to inject a cc_feature. This allows a user to inject a feature (for example for custom warnings) without having to reimplement the full toolchain.
Resolves #517