Propagate AppleFrameworkImportInfo from iOS extensions
#2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pping frameworks get imported into the main bundle
aaronsky
changed the title
aaronsky
changed the title
AppleFrameworkImportInfo from extensions
aaronsky
changed the title
AppleFrameworkImportInfo from extensionsAppleFrameworkImportInfo from iOS extensions
aaronsky
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
luispadron
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am attempting to cover for a seemingly specific edge-case. Maybe misguided, but it can be validated with the tests on this PR. Here goes:
Given an
ios_extensionthat depends on anapple_dynamic_xcframework_import(I assume this also affectsapple_dynamic_framework_importbut have not tested it), and given anios_applicationthat bundles this extension but does not depend on the imported framework, then the Mach-O load command is added to the extension binary, but the framework is not bundled in$BUNDLE_ROOT/Frameworks. This causes the extension to crash at launch. Slack thread for additional context.Based on my read of the code in
ios_rules.bzl, this feels like an oversight, given that this line takesctx.attr.extensionsand attempts to loadAppleFrameworkImportInfoproviders on this line, but without this PR that doesn't seem as though it will never happen based on this line. Happy to discuss if my interpretation is off-base!