Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bundling live activities extensions with ios_app_clip #2630

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support bundling live activities extensions with ios_app_clip #2630

wants to merge 3 commits into from
+66 −6

Conversation

adincebic
Copy link
Contributor

@adincebic adincebic commented Jan 14, 2025 •
edited
Loading

Per Apple's documentation we are allowed to bundle extensions with app clips but only live activities.

This pull request adds support for that.

  • Checks for live activity so that no one tries to bundle standard iOS extension. These are not worth persuing as vanilla Xcode does not do it. The verification happens at the level of entitlements, meaning that correct entitlement must be present to be able to submit an app clip with live activity extension to the AppStore.
  • Documentation.
  • Tests

@adincebic adincebic marked this pull request as draft January 14, 2025 13:07
@adincebic adincebic force-pushed the adin/suppport-live-activities-in-app-clips branch from d8e06a5 to 9d68c61 Compare January 14, 2025 16:53
@adincebic
Update docs
94cb077 
Signed-off-by: Adin Cebic <[email protected]>
@adincebic adincebic force-pushed the adin/suppport-live-activities-in-app-clips branch from 8790f0b to 94cb077 Compare January 18, 2025 06:53
@adincebic
Add tests
e4b90f0 
Signed-off-by: Adin Cebic <[email protected]>
@adincebic adincebic marked this pull request as ready for review January 19, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronsky aaronsky Awaiting requested review from aaronsky aaronsky is a code owner

@BalestraPatrick BalestraPatrick Awaiting requested review from BalestraPatrick BalestraPatrick is a code owner

@brentleyjones brentleyjones Awaiting requested review from brentleyjones brentleyjones is a code owner

@keith keith Awaiting requested review from keith keith is a code owner

@luispadron luispadron Awaiting requested review from luispadron luispadron is a code owner

@mattrobmattrob mattrobmattrob Awaiting requested review from mattrobmattrob mattrobmattrob is a code owner

@thii thii Awaiting requested review from thii thii is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adincebic