[AOSP-pick] Remove default helper methods in BuildResultHelper #7229
+34
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utility methods are supposed to be static in preferably in utility classes or as Kotlin extension methods. This is to enable safe and bigger refactoring of this area of code. Bug: n/a Test: n/a Change-Id: I9dd7c5515c3289b05042299c6aea3d5c70c70180 AOSP: ccf72a5c77927d76c9e7cf55378ea1fc6aec6334
github-actions
bot
added
product: CLion
ujohnny
reviewed
Jan 21, 2025
| @@ -83,6 +83,7 @@ java_library( | |||
| "//intellij_platform_sdk:plugin_api", | |||
| "//sdkcompat", | |||
| "//clwb/sdkcompat", | |||
| "//shared", | |||
There was a problem hiding this comment.
is the order correct here, ie why clwb is inbetween?
There was a problem hiding this comment.
No it's not. I'll format the entire file in a new PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick AOSP commit ccf72a5c77927d76c9e7cf55378ea1fc6aec6334.
Utility methods are supposed to be static in preferably in utility
classes or as Kotlin extension methods.
This is to enable safe and bigger refactoring of this area of code.
Bug: n/a
Test: n/a
Change-Id: I9dd7c5515c3289b05042299c6aea3d5c70c70180
AOSP: ccf72a5c77927d76c9e7cf55378ea1fc6aec6334